Add client SFTP Key file support and fix docs #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The config documentation claims that `ClientPrivateKey` should be a filename but in reality it needs to be the raw key string. I've fixed that documentation, but also added a `ClientPrivateKeyFile` config for flexibility with sourcing the client private key from the filesystem.
kevinbarbour
changed the title
adamdecaf
approved these changes
Jul 11, 2024
|
Released in https://github.com/moov-io/achgateway/releases/tag/v0.31.0, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The config documentation claims that
ClientPrivateKeyshould be a filename but in reality it needs to be the raw key string. I've fixed that documentation, but also added aClientPrivateKeyFileconfig for flexibility with sourcing the client private key from the filesystem.Why Are Changes Being Made
Fixes an incorrect documentation statement, and allows flexibility on deployment by storing private keys on the filesystem instead of in configuration files.