-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Payload format verification and content type properties handling #826
Merged
andsel
merged 15 commits into
moquette-io:main
from
andsel:feature/verify_payload_format_indicator_content_type
May 25, 2024
Merged
Payload format verification and content type properties handling #826
andsel
merged 15 commits into
moquette-io:main
from
andsel:feature/verify_payload_format_indicator_content_type
May 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
andsel
force-pushed
the
feature/verify_payload_format_indicator_content_type
branch
from
April 20, 2024 09:50
7e94b10
to
1300eff
Compare
2 tasks
andsel
force-pushed
the
feature/verify_payload_format_indicator_content_type
branch
from
April 20, 2024 15:02
1300eff
to
8d00d30
Compare
andsel
force-pushed
the
feature/verify_payload_format_indicator_content_type
branch
from
May 1, 2024 10:51
8a6a382
to
bd9e93c
Compare
andsel
changed the title
[test] add test to verify that payload format indicator is forwarded
Payload format verification
May 1, 2024
andsel
changed the title
Payload format verification
Payload format verification and content type properties handling
May 25, 2024
…is case the payload format indicator is forwarded
…n't forward the publish
…ins invalid UTF8 payload and payload format indicator property is set, then return an error code
…indicator is set and the payload is not UTF8
andsel
force-pushed
the
feature/verify_payload_format_indicator_content_type
branch
from
May 25, 2024 08:46
0f2b22e
to
99cf4da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
Manage payload format indicator property, when set verify payload format.
What does this PR do?
Updates the processing of publish messages (for all QoS) to verify the payload to be encoded in UTF-8 when property
payload format indicator
is set. If the validation fails, return an acknowledgement message (PUBACK for QoS1 and PUBREC for QoS2, and DISCONNECT for QoS0) with an appropriate return code.Manage also
content_type
property.Why is it important/What is the impact to the user?
Implement
payload format indicator
andcontent_type
property for MQTT5.Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files (and/or docker env variables)Related issues