Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payload format verification and content type properties handling #826

Conversation

andsel
Copy link
Collaborator

@andsel andsel commented Apr 19, 2024

Release notes

Manage payload format indicator property, when set verify payload format.

What does this PR do?

Updates the processing of publish messages (for all QoS) to verify the payload to be encoded in UTF-8 when property payload format indicator is set. If the validation fails, return an acknowledgement message (PUBACK for QoS1 and PUBREC for QoS2, and DISCONNECT for QoS0) with an appropriate return code.
Manage also content_type property.

Why is it important/What is the impact to the user?

Implement payload format indicator and content_typeproperty for MQTT5.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the Changelog if it's a feature or a fix that has to be reported

Related issues

@andsel andsel added the mqtt5 label Apr 19, 2024
@andsel andsel self-assigned this Apr 19, 2024
@andsel andsel force-pushed the feature/verify_payload_format_indicator_content_type branch from 7e94b10 to 1300eff Compare April 20, 2024 09:50
@andsel andsel force-pushed the feature/verify_payload_format_indicator_content_type branch from 1300eff to 8d00d30 Compare April 20, 2024 15:02
@andsel andsel force-pushed the feature/verify_payload_format_indicator_content_type branch from 8a6a382 to bd9e93c Compare May 1, 2024 10:51
@andsel andsel mentioned this pull request May 1, 2024
5 tasks
@andsel andsel changed the title [test] add test to verify that payload format indicator is forwarded Payload format verification May 1, 2024
@andsel andsel marked this pull request as ready for review May 1, 2024 16:57
@andsel andsel changed the title Payload format verification Payload format verification and content type properties handling May 25, 2024
@andsel andsel force-pushed the feature/verify_payload_format_indicator_content_type branch from 0f2b22e to 99cf4da Compare May 25, 2024 08:46
@andsel andsel merged commit 031e77b into moquette-io:main May 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant