-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/resolve flaky error in tests #872
Merged
andsel
merged 10 commits into
moquette-io:main
from
andsel:fix/resolve_flaky_error_in_tests
Nov 23, 2024
Merged
Fix/resolve flaky error in tests #872
andsel
merged 10 commits into
moquette-io:main
from
andsel:fix/resolve_flaky_error_in_tests
Nov 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uld read null values
andsel
commented
Nov 23, 2024
broker/src/test/java/io/moquette/integration/mqtt5/PayloadFormatIndicatorTest.java
Outdated
Show resolved
Hide resolved
andsel
commented
Nov 23, 2024
receivedTopic = topic; | ||
receivedMessage = message; | ||
latch.countDown(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switch the order so that the latch release happens only after the data has been copied, else the client can read null values.
…ceives the PUB doesn't forward imemdiately
andsel
force-pushed
the
fix/resolve_flaky_error_in_tests
branch
from
November 23, 2024 17:51
9319da3
to
2c57034
Compare
…before triggering the action
andsel
force-pushed
the
fix/resolve_flaky_error_in_tests
branch
from
November 23, 2024 18:00
2c57034
to
249967a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
[rn:skip]
What does this PR do?
Fixes some flaky test acting on 3 things:
From
to