Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

result.fix.match() assertion will use the tags present in the expected message when include_only_expected parameter set to True #1009

Merged
merged 13 commits into from
Nov 17, 2023
Merged

result.fix.match() assertion will use the tags present in the expected message when include_only_expected parameter set to True #1009

merged 13 commits into from
Nov 17, 2023

Conversation

rnemes
Copy link
Contributor

@rnemes rnemes commented Oct 27, 2023 •
edited
Loading

Solution description

result.fix.match() assertion will use the tags present in the expected message when include_only_expected parameter set to True

Checklist:

  • Test
  • Example (both test_plan.py and .rst)
  • Documentation (API)
  • News fragment present for release notes
  • MS info leakage check
  • For new driver: driver index page
  • For new assertion: ui/pdf/std renderers, documentation
  • For new cmdline arg: documentation

@rnemes rnemes requested a review from Pyifan as a code owner October 27, 2023 13:53
@rnemes rnemes requested review from kn-ms and M6AI October 27, 2023 13:53
Pyifan
Pyifan reviewed Oct 30, 2023
View reviewed changes
Copy link
Contributor

@Pyifan Pyifan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dictmatch works in a recursive way, I think the expected behavior is to only compare the tags that are present in expected msg at each level. Flatten into a list upfront will behave differently.

@rnemes rnemes changed the title result.fix.match() now supports repeating groups result.fix.match() assertion will use the tags present in the expected message when include_tags parameter set to True Nov 6, 2023
Pyifan
Pyifan requested changes Nov 10, 2023
View reviewed changes
testplan/common/utils/comparison.py Outdated Show resolved Hide resolved
@rnemes rnemes changed the title result.fix.match() assertion will use the tags present in the expected message when include_tags parameter set to True result.fix.match() assertion will use the tags present in the expected message when include_only_tags_of_expected parameter set to True Nov 14, 2023
@rnemes rnemes requested a review from Pyifan November 14, 2023 13:59
Pyifan
Pyifan requested changes Nov 15, 2023
View reviewed changes
doc/newsfragments/2691_changed.fix_match_assertion.rst Outdated Show resolved Hide resolved
testplan/common/utils/comparison.py Outdated Show resolved Hide resolved
@rnemes rnemes changed the title result.fix.match() assertion will use the tags present in the expected message when include_only_tags_of_expected parameter set to True result.fix.match() assertion will use the tags present in the expected message when include_only_expected parameter set to True Nov 15, 2023
@rnemes rnemes requested review from Pyifan and M6AI November 15, 2023 14:23
@rnemes rnemes merged commit 3169967 into morganstanley:main Nov 17, 2023
15 checks passed
@rnemes rnemes deleted the FixMatchAssertion branch November 17, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kn-ms kn-ms kn-ms approved these changes

@Pyifan Pyifan Pyifan approved these changes

@M6AI M6AI Awaiting requested review from M6AI

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rnemes @Pyifan @kn-ms @M6AI