-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change minimum Python version to 3.10 #1172
Open
zsambokiandras
wants to merge
10
commits into
morganstanley:main
Choose a base branch
from
zsambokiandras:use_py310_deprecate_37
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Change minimum Python version to 3.10 #1172
zsambokiandras
wants to merge
10
commits into
morganstanley:main
from
zsambokiandras:use_py310_deprecate_37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hi Andras, let's add a newsfrag, stating we are going to drop support for python <3.10 in 4 weeks' time. And keep 3.7, 3.8 test job for now, and let's remove later. |
Pyifan
reviewed
Jan 16, 2025
zhenyu-ms
requested changes
Jan 16, 2025
doc/en/getting_started.rst
Outdated
|
||
You will need a working python 3.7+ interrpreter preferably a venv, and for the interactive ui you need node installed. | ||
You will need a working python 3.10+ interpreter preferably a venv, and for the interactive ui you need node installed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually i don't think we need to mention minor python versions here
Co-authored-by: Zhenyu Yao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug / Requirement Description
Drop support for py 3.7 and 3.8, minimum version is 3.10+.
Solution description
Changed documentation and config files.
Checklist: