Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/rounded steps #758

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Feature/rounded steps #758

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a3a1ecc
Add rounding option for steps on the y axis
theanchorsmith Mar 21, 2018
f9ec37b
Add the recommended package-lock file
theanchorsmith Mar 21, 2018
0c29190
Bugfix to prevent a step size of zero
theanchorsmith Mar 21, 2018
f660b8e
New built
theanchorsmith Mar 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/morris.grid.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,8 @@ class Morris.Grid extends Morris.EventEmitter
dateFormat: null
axes: true
freePosition: false
grid: true
grid: true,
roundYSteps: false,
gridLineColor: '#aaa'
gridStrokeWidth: 0.5
gridTextColor: '#888'
Expand Down Expand Up @@ -264,6 +265,11 @@ class Morris.Grid extends Morris.EventEmitter
gmin = Math.floor(ymin / unit) * unit
gmax = Math.ceil(ymax / unit) * unit
step = (gmax - gmin) / (nlines - 1)

# round steps for the Y axes
if this.options.roundYSteps
step = Math.ceil(step)

if unit == 1 and step > 1 and Math.ceil(step) != step
step = Math.ceil(step)
gmax = gmin + step * (nlines - 1)
Expand Down
Loading