Bug 1861888 - Requiring Staff To Use Duo 2FA On Bugzilla #2145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgsheeh
approved these changes
Jan 9, 2024
Bugzilla/WebService/User.pm
Outdated
| @@ -352,6 +375,14 @@ sub get { | |||
| } | |||
| } | |||
|
|
|||
| # If calling user is member of mozilla-employee-confidential, | |||
| # return ldap_email value as well | |||
| if (Bugzilla->user->in_group('mozilla-employee-confidential') | |||
There was a problem hiding this comment.
Nit: you can use $user here.
|
I updated the code in Bugzilla/WebService/User.pm get() to have more consistent variable naming when dealing with the logged in user and the user objects being returned. Hopefully the code is less confusing now and less error prone. |
…requirement may have changed
…up memberships. This way we can log out the user if their duo requirement status changes
…le naming of user objects in get()
…requirement - Updated icon - Updated test script
|
Re-requesting review: Test script has been updated to cover more functionality. I am now setting the mfa_required_date to a date in the past (immediate change needed) which should require the user to setup TOTP when removed from the duo_required_group. |
…g other test to fail
cgsheeh
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
duo_required_groupandduo_required_excluded_group.duo_required_groupwill automatically be redirected to the MFA preferences page if their current MFA is not set toDuo.Duofor their account using the standard enrollment procedure.duo_required_excluded_group, then they will not be redirected to the MFA page and will operate normally.