Skip to content

Commit

Permalink
Bug 1567912 - Specify mime type for AAB upload and bump mozapkpublish…
Browse files Browse the repository at this point in the history
…er version (#247)
  • Loading branch information
gbrownmozilla authored Sep 21, 2023
1 parent f228d85 commit 0affd28
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 3 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).

## [6.2.1] - 2023-09-21

### Fixed
* Specify media mime type for AAB uploads

## [6.2.0] - 2023-09-11

### Added
Expand Down
7 changes: 5 additions & 2 deletions mozapkpublisher/common/store.py
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,9 @@ def upload_apk(self, apk):
response = self._edit_resource.apks().upload(
editId=self._edit_id,
packageName=self._package_name,
media_body=apk_path
media_body=apk_path,
# Seems like mime type need not be specified for apk files:
# media_mime_type='application/octet-stream',
).execute()
logger.info('"{}" uploaded'.format(apk_path))
logger.debug('Upload response: {}'.format(response))
Expand All @@ -234,7 +236,8 @@ def upload_aab(self, aab):
response = self._edit_resource.bundles().upload(
editId=self._edit_id,
packageName=self._package_name,
media_body=aab_path
media_body=aab_path,
media_mime_type='application/octet-stream',
).execute()
logger.info('"{}" uploaded'.format(aab_path))
logger.debug('Upload response: {}'.format(response))
Expand Down
1 change: 1 addition & 0 deletions mozapkpublisher/test/common/test_store.py
Original file line number Diff line number Diff line change
Expand Up @@ -510,6 +510,7 @@ def test_google_upload_aab_returns_files_metadata(edit_resource_mock):
editId=google_play._edit_id,
packageName='dummy_package_name',
media_body='/path/to/dummy.aab',
media_mime_type='application/octet-stream',
)


Expand Down
2 changes: 1 addition & 1 deletion version.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
6.2.0
6.2.1

0 comments on commit 0affd28

Please sign in to comment.