-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Motorola Surnia Backlight Driver V2 #296
base: msm8916/6.2-rc5
Are you sure you want to change the base?
Motorola Surnia Backlight Driver V2 #296
Conversation
5af718d
to
5d3996d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly nitpicks
5d3996d
to
5bf4ff8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also the usual commit order is bindings then driver then dt changes adding users
5bf4ff8
to
cf00732
Compare
Re-ordered the commits, but I assume that only the first 2 will be upstreamed and the dts will go into pmaports. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Driver commit is still before the dt-bindings, please swap them around
20a27d4
to
bb2077e
Compare
4882044
to
114ac8e
Compare
Added documentation for the rohm,bd65b60 led driver. Signed-off-by: Bogdan Ionescu <[email protected]>
The chip supports 2 outpus sharing the same current setting and is controlled over I2C. Signed-off-by: Bogdan Ionescu <[email protected]>
Enabling backlight brightness control for motorola-surnia. Signed-off-by: Bogdan Ionescu <[email protected]>
Based on motorola-surnia, the only changes being: - Using LED2 instead of LED1 for the led driver - Using GPIO 113 for the backlight reset Signed-off-by: Bogdan Ionescu <[email protected]>
114ac8e
to
469db74
Compare
Added support for brightness control for motorola-surnia (sprey and styx too) though led-backlight driver and rohm bd65b60 driver.
Re-submission of #284
I re-wrote the driver from scratch, it was more fun than I expected. Hopefully this time its easier to review. I've done my best to check the coding standards, examples and old PRs for guidance.