Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fmt: update to 8.0.1 #8975

Merged
merged 4 commits into from
Jul 6, 2021
Merged

fmt: update to 8.0.1 #8975

merged 4 commits into from
Jul 6, 2021

Conversation

bbolli
Copy link
Contributor

@bbolli bbolli commented Jun 21, 2021

No description provided.

@lazka
Copy link
Member

lazka commented Jun 22, 2021

Should we try to rebuild the reverse dependencies with this?

@bbolli
Copy link
Contributor Author

bbolli commented Jun 22, 2021

If you can find them out easily, then yes, please!

@Biswa96
Copy link
Member

Biswa96 commented Jun 22, 2021

@lazka
Copy link
Member

lazka commented Jun 29, 2021

Blocking on gabime/spdlog#1975

@bbolli
Copy link
Contributor Author

bbolli commented Jul 4, 2021

There's already a fmt v8.0.1 out...

@lazka
Copy link
Member

lazka commented Jul 4, 2021

Maybe we should just backport gabime/spdlog#1976 ?

@bbolli
Copy link
Contributor Author

bbolli commented Jul 4, 2021

So spdlog uses the packaged fmt, not a bundled one? Anyway, that PR looks low-risk, so yeah, let's to this. Should I amend this PR then?

@lazka
Copy link
Member

lazka commented Jul 4, 2021

So spdlog uses the packaged fmt, not a bundled one?

Not sure tbh. edit:

-DSPDLOG_FMT_EXTERNAL=ON \

Anyway, that PR looks low-risk, so yeah, let's to this. Should I amend this PR then?

sure, thanks

bbolli added 2 commits July 4, 2021 23:05
Apply the patch from gabime/spdlog#1976 while
spdlog hasn't released a version compatible with fmt 8.0.x.
@bbolli bbolli changed the title fmt: update to 8.0.0 fmt: update to 8.0.1 Jul 4, 2021
@lazka lazka merged commit af24226 into msys2:master Jul 6, 2021
@lazka
Copy link
Member

lazka commented Jul 6, 2021

thanks

@bbolli bbolli deleted the fmt-8.0.0 branch July 6, 2021 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants