Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update to windows-sys 0.52.0 #109

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Conversation

poliorcetics
Copy link
Contributor

@poliorcetics poliorcetics commented Nov 16, 2023

windows-sys moved its MSRV to 1.56, which is less or equal to the one in this crate since the
edition for windows-service is 2021, so no impact there.

Could we have a release after this is merged ? I don't see any pub use of windows_sys:: stuff
so a point release should be enough.
windows-sys is part of the public API so it would need a breaking release.


This change is Reviewable

@faern
Copy link
Member

faern commented Nov 16, 2023

Thanks for the PR!

windows-sys is part of our public API. For example in a bunch of to_raw methods, such as ServiceAction::to_raw for example. This means we need to bump our version in a breaking way, not just a patch release. However, you should not bump the version in this PR. That's something we do when releasing as part of regular release work.

I don't know exactly what changed in the new version of the crate, but I guess it's nice we did not need any code changes to make it work :)

The CI fails, but I don't think it's because of these changes...

@faern
Copy link
Member

faern commented Nov 16, 2023

Here is why the CI is failing: egor-tensin/setup-mingw#15

@faern
Copy link
Member

faern commented Nov 17, 2023

@poliorcetics We have now fixed the mingw issue. You can rebase this PR and push it to see if it works now.

@poliorcetics
Copy link
Contributor Author

Thanks for the notif, rebased 👍

Copy link
Member

@dlon dlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@dlon dlon merged commit 1bb3ff1 into mullvad:main Nov 20, 2023
8 checks passed
@dlon
Copy link
Member

dlon commented Nov 20, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants