-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare to release 0.7.0 #125
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @faern)
CHANGELOG.md
line 23 at r2 (raw file):
### Changed - Breaking: Make a bunch of enums `#[non_exhaustive]`: `Error`, `PowerBroadcastSetting`, `PowerEventParam`, `SessionChangeReason` and `ServiceControl`.
SessionChangeReason
should be removed from here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dlon)
CHANGELOG.md
line 23 at r2 (raw file):
Previously, dlon (David Lönnhager) wrote…
SessionChangeReason
should be removed from here.
That's an error in the previous PR, but yes, you are right! Fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
Published to crates.io and tag pushed: https://github.com/mullvad/windows-service-rs/releases/tag/v0.7.0 |
Lots of stuff has happened and a full year has passed since 0.6.0. It's about time we get with the times. Here I prepare for releasing 0.7.0. It's a breaking release because we upgrade
windows-sys
I want #124 merged before we go ahead with this release.
This change is