Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare to release 0.7.0 #125

Merged
merged 5 commits into from
Apr 16, 2024
Merged

Prepare to release 0.7.0 #125

merged 5 commits into from
Apr 16, 2024

Conversation

faern
Copy link
Member

@faern faern commented Apr 12, 2024

Lots of stuff has happened and a full year has passed since 0.6.0. It's about time we get with the times. Here I prepare for releasing 0.7.0. It's a breaking release because we upgrade windows-sys

I want #124 merged before we go ahead with this release.


This change is Reviewable

@faern faern requested a review from dlon April 12, 2024 15:15
@faern faern mentioned this pull request Apr 12, 2024
Copy link
Member

@dlon dlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Member

@dlon dlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @faern)


CHANGELOG.md line 23 at r2 (raw file):

### Changed
- Breaking: Make a bunch of enums `#[non_exhaustive]`: `Error`, `PowerBroadcastSetting`,
  `PowerEventParam`, `SessionChangeReason` and `ServiceControl`.

SessionChangeReason should be removed from here.

Copy link
Member Author

@faern faern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dlon)


CHANGELOG.md line 23 at r2 (raw file):

Previously, dlon (David Lönnhager) wrote…

SessionChangeReason should be removed from here.

That's an error in the previous PR, but yes, you are right! Fixed

Copy link
Member

@dlon dlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@faern faern merged commit 7229110 into main Apr 16, 2024
9 checks passed
@faern faern deleted the prepare-0.7.0 branch April 16, 2024 08:13
@faern
Copy link
Member Author

faern commented Apr 16, 2024

Published to crates.io and tag pushed: https://github.com/mullvad/windows-service-rs/releases/tag/v0.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants