This repository has been archived by the owner on Oct 5, 2021. It is now read-only.
Tor integration: TorDialer and OnionListener #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yep-- what do you think of this comment: ipfs/notes#37 (comment) -- and maybe we should discuss that here: #7 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Juan,
What do you think of these code changes so far?
Clearly it's mostly client side changes now... I haven't yet adjusted the Listener code much... because there are some open API design questions... In particular it seems that go-ipfs expects to create multiaddr-net Listener by simply giving it a multiaddr... however for the Tor OnionListener case we need to either already have onion key material or we need auto-create a new onion address. Either way we have a slight API impedance mismatch. How shall we solve this? I've also commented on it here:
ipfs/notes#37 (comment)