Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dms3 draft codec request #366

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

dms3 draft codec request #366

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
772e060
dms3 draft codec request
Dec 13, 2024
99a19d7
move dms3 entries at range suggest by Rod, to end of table
Jan 6, 2025
0a8c177
Merge branch 'master' into dms3-codec
yozgatsi Jan 6, 2025
083e4e8
modify pull request
Jan 6, 2025
cbe4e3d
fix row line order problem
Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions table.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,6 +557,8 @@ eip-191, varsig, 0xd191, draft, EIP-
jwk_jcs-pub, key, 0xeb51, draft, JSON object containing only the required members of a JWK (RFC 7518 and RFC 7517) representing the public key. Serialisation based on JCS (RFC 8785)
fil-commitment-unsealed, filecoin, 0xf101, permanent, Filecoin piece or sector data commitment merkle node/root (CommP & CommD)
fil-commitment-sealed, filecoin, 0xf102, permanent, Filecoin sector data commitment merkle node/root - sealed and replicated (CommR)
dms3, multiaddr, 0x100000, draft, Decentralized Multi-State-Space Search
dms3-key, ipld, 0x100001, draft, DMS3 Public Key
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
dms3-key, ipld, 0x100001, draft, DMS3 Public Key
dms3-key, key, 0x100001, draft, Decentralized Multi-State-Space Search Public Key

unfortunately you can't use ipld if this isn't a codec that can decode bytes into something that can contain links; if it's a codec that doesn't involve links then it's a serialization, but given you're saying it's a public key then I suspect it's not even that.

I'd suggest it's probably just a key, but you also may want to consider the name dms3-pub to match the other public key types. But this also raises the question: is this actually a key type? Can you just use one (or more) of the existing key types for this?

shelter-contract-manifest, shelter, 0x511e00, draft, Shelter protocol contract manifest
shelter-contract-text, shelter, 0x511e01, draft, Shelter protocol contract text
shelter-contract-data, shelter, 0x511e02, draft, Shelter protocol contract data (contract chain)
Expand Down
Loading