support io (read/write) without core #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This: 1. Uses core2 when std isn't supported. 2. Adds an alloc feature for building with and without the alloc crate. Uses multiformats/rust-multihash#146. Unfortunately, we can't do multibase formatting yet due to multiformats/rust-multibase#33. But we can fix that later.
| pub fn to_bytes(&self) -> Vec<u8> { | ||
| let mut bytes = vec![]; |
There was a problem hiding this comment.
Do you want to add #![cfg_attr(feature = "alloc", macro_use)] to lib.rs and keep this? It seems fine either way.
There was a problem hiding this comment.
I think it's easier to just use the constructor. Honestly, the macro was mostly useful as an efficient way to allocate vectors with a slice-like syntax before const generics.
vmx
approved these changes
Oct 29, 2021
|
Merged into the branch "next". I'll merge that into master when we're ready to release both this and mutlihash. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This:
Uses multiformats/rust-multihash#146.
Unfortunately, we can't do multibase formatting yet due to multiformats/rust-multibase#33. But we can fix that later.