feat: add support for PUID and PGID environment variables #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this going to be merged? It's really useful. |
|
I can answer that once I have found the time to review this PR |
Krzmbrzl
force-pushed
the
puidpgid
branch
2 times, most recently
from
b9a9f45 to
d1be2e6
Compare
This commit removes the hardcoded MUMBLE_UID and MUMBLE_GID and instead adopts the commonly used PUID and PGID environment variables for setting the desired UID:GID for mumble-server to run as. For backwards-compatibility they still default to 10000:10000. Also, a new variable `MUMBLE_CHOWN_DATA` is used to define whether to chown `/data` and its contents or not. Fixes mumble-voip#34 Signed-off-by: Nita Vesa <[email protected]>
|
Thank you for implementing this 👍 |
|
Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the hardcoded MUMBLE_UID and MUMBLE_GID and instead adopts the commonly used PUID and PGID environment variables for setting the desired UID:GID for mumble-server to run as. For backwards-compatibility they still default to 10000:10000.
Also, a new variable
MUMBLE_CHOWN_DATAis used to define whether to chown/dataand its contents or not.Fixes #34