-
-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up outdated code, dependencies, documentation, etc. #532
Conversation
Pull Request Test Coverage Report for Build 1281
💛 - Coveralls |
Are you doing a scream test on the mysql logger? |
Hah, walked right into that one. 🤦 In all seriousness though, the MySQL logger has been broken and disabled for two and a half years, ever since the switch from Python 3 apparently. The tests are never run and carry this message: conpot/conpot/tests/test_logger_mysql.py Lines 23 to 24 in 68702a4
Only the "wiring" was never removed so the dependencies still needed to be installed. Since it was commented out code it got swept up in this cleanup. If you prefer to keep it in I'll push a revert commit for 07b13a8. EDIT: I fail at math. |
Don't get me wrong, I'm all in favor of removing the MySQL logger :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Nice work @srenfo , your contributions to Conpot are much appreciated. |
Cleans up a bunch of unused code, outdated dependencies, orphaned documentation and obsolete configuration.
The PR is structured such that individual changes can be undone with revert commits.
However, this is not comprehensive. You can find more stuff to remove if you want to. For example, there are more orphaned documentation files and there are old scripts in
bin/
where I'm not sure if they're still functional or needed.I tried to keep the individual commit messages concise and meaningful for easier navigation.