Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve dispose/cancellation error handling #28

Merged
merged 3 commits into from
Jan 30, 2024
Merged

Conversation

joaoborks
Copy link
Member

No description provided.

@joaoborks joaoborks self-assigned this Jan 30, 2024
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (fae1cf4) 90.32% compared to head (f14d79f) 89.94%.
Report is 1 commits behind head on main.

Files Patch % Lines
...oader/Runtime/SceneLoaders/SceneLoaderCoroutine.cs 90.54% 7 Missing ⚠️
...s-scene-loader/Runtime/Utilities/TaskExtensions.cs 75.86% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
- Coverage   90.32%   89.94%   -0.39%     
==========================================
  Files          18       19       +1     
  Lines         961     1014      +53     
==========================================
+ Hits          868      912      +44     
- Misses         93      102       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joaoborks joaoborks merged commit 2bfbcb9 into main Jan 30, 2024
4 checks passed
@joaoborks joaoborks deleted the fix/error-handling branch January 30, 2024 20:50
joaoborks pushed a commit that referenced this pull request Jan 30, 2024
## [2.3.1](2.3.0...2.3.1) (2024-01-30)

### Bug Fixes

* improve dispose/cancellation error handling ([#28](#28)) ([2bfbcb9](2bfbcb9))
@joaoborks
Copy link
Member Author

🎉 This PR is included in version 2.3.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Jan 30, 2024
## [2.3.1](2.3.0...2.3.1) (2024-01-30)

### Bug Fixes

* improve dispose/cancellation error handling ([#28](#28)) ([2bfbcb9](2bfbcb9))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant