-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support GJS 1.72 Shell 42 #217
Merged
Merged
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
b0c4b11
fix _syncStacking error
ebeem 1b51812
Support GJS 1.72: call hookVfunc on gobject prototype.
ettavolt 7c9c28f
Copy 42's changes to ControlsManagerLayout._computeWorkspacesBoxForSt…
ettavolt a3df0ae
Some overrides for inaccessible Shell UI bits.
ettavolt c8a87ef
Update default settings
mzur 423e1e1
Move ControlsState import
mzur 09af7f3
Move code to better match upstream
mzur 4bd10fb
Update [email protected]/workspacePopup/workspaceAnimation.js
mzur 174fa3c
Disable secondaryMonitorDisplayOverride
mzur File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,6 @@ | ||
{ | ||
"shell-version": [ | ||
"40", | ||
"41" | ||
"42" | ||
], | ||
"uuid": "[email protected]", | ||
"url": "https://github.com/mzur/gnome-shell-wsmatrix", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,8 +2,10 @@ const {GObject, Meta, St} = imports.gi; | |
|
||
const Main = imports.ui.main; | ||
const GWorkspaceAnimation = imports.ui.workspaceAnimation; | ||
|
||
const { WORKSPACE_SPACING } = GWorkspaceAnimation; | ||
const ExtensionUtils = imports.misc.extensionUtils; | ||
const Self = ExtensionUtils.getCurrentExtension(); | ||
const Util = Self.imports.util; | ||
const {WORKSPACE_SPACING} = GWorkspaceAnimation; | ||
|
||
const MonitorGroup = GObject.registerClass( | ||
class MonitorGroup extends GWorkspaceAnimation.MonitorGroup { | ||
|
@@ -37,10 +39,6 @@ class MonitorGroup extends GWorkspaceAnimation.MonitorGroup { | |
} | ||
|
||
const group = new GWorkspaceAnimation.WorkspaceGroup(ws, monitor, movingWindow); | ||
// avoid warnings | ||
group._syncStacking = () => { | ||
}; | ||
|
||
this._workspaceGroups.push(group); | ||
this._container.add_child(group); | ||
group.set_position(x, y); | ||
|
@@ -132,7 +130,7 @@ class MonitorGroup extends GWorkspaceAnimation.MonitorGroup { | |
} | ||
}); | ||
|
||
class WorkspaceAnimationController extends GWorkspaceAnimation.WorkspaceAnimationController { | ||
var WorkspaceAnimationController = class WorkspaceAnimationController extends GWorkspaceAnimation.WorkspaceAnimationController { | ||
_prepareWorkspaceSwitch(workspaceIndices) { | ||
if (this._switchData) | ||
return; | ||
|
@@ -169,3 +167,38 @@ class WorkspaceAnimationController extends GWorkspaceAnimation.WorkspaceAnimatio | |
Meta.disable_unredirect_for_display(global.display); | ||
} | ||
} | ||
|
||
var WorkspaceGroup = class { | ||
constructor() { | ||
this.originalLayout = null; | ||
this._overrideProperties = { | ||
_syncStacking() { | ||
const windowActors = global.get_window_actors().filter(w => | ||
this._shouldShowWindow(w.meta_window)); | ||
|
||
let lastRecord; | ||
|
||
for (const windowActor of windowActors) { | ||
const record = this._windowRecords.find(r => r.windowActor === windowActor); | ||
|
||
if (record && lastRecord) { | ||
this.set_child_above_sibling(record.clone, lastRecord ? lastRecord.clone : this._background); | ||
lastRecord = record; | ||
} | ||
} | ||
}, | ||
Comment on lines
+258
to
+272
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @ettavolt Could you please explain why this is override necessary? The |
||
} | ||
} | ||
|
||
destroy() { | ||
this.restoreOriginalProperties(); | ||
} | ||
|
||
overrideOriginalProperties() { | ||
this.originalLayout = Util.overrideProto(GWorkspaceAnimation.WorkspaceGroup.prototype, this._overrideProperties); | ||
} | ||
|
||
restoreOriginalProperties() { | ||
Util.overrideProto(GWorkspaceAnimation.WorkspaceGroup.prototype, this.originalLayout); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an incompatible change. @mzur, would you please open a shell-42 branch (or take this as it)?