Fix bad json error handling, test error states #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is similar to: #46 but from my testing, the error callback is triggered, not the success callback (with jQuery) |
* Return original responseText in errors. Stack trace is available in error (3rd argument)
demersus
force-pushed
the
error-tests-parse-error
branch
from
62fa832 to
360ed15
Compare
|
👍 thanks @demersus! |
alanclarke
approved these changes
Mar 15, 2017
Closed
demersus
added a commit
to demersus/fastboot
that referenced
this pull request
Mar 15, 2017
The upgrade contains an important fix for catching errors when an assumed json endpoint returns html. This can happen when the gateway times out. See: najaxjs/najax#56
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From my testing with jQuery: jQuery will trigger the error callback with an untouched jqXHR object, a statusText of 'parseerror', and a SyntaxError - when it can't parse the response json.
This PR does a couple things: