Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mailto support for CAA 'iodef' (ref: #73) #90

Closed
wants to merge 2 commits into from

Conversation

LarsArtmann
Copy link

#73

@vetal2409
Copy link
Contributor

Hello! Thanks for your contribution!
@LarsArtmann Could you please sign off your commit to pass the DCO check?

@LarsArtmann
Copy link
Author

@vetal2409 commits are signed off, DCO passes

@LarsArtmann
Copy link
Author

Can somebody merge this?

@kurok
Copy link
Collaborator

kurok commented Nov 21, 2024

I will pass it to right person - thank for contribute

@vetal2409 vetal2409 force-pushed the master branch 4 times, most recently from fa0b22d to 1421147 Compare November 28, 2024 18:28
@fdrvrtm
Copy link

fdrvrtm commented Nov 29, 2024

Hi @LarsArtmann,

Thank you for your valuable contribution!

Your changes have been merged directly into the go-namecheap-sdk and are included in the v2.4.0 release of the SDK.

Since this SDK is used within our provider, we have updated its version accordingly, which brings your code changes into our codebase.

For those following this MR and interested in incorporating this fix into their environment, please use the latest version of the provider (currently v2.2.0). This should resolve the issue you've encountered.

If the issue is resolved, we would greatly appreciate your feedback.

Thanks again!

@vetal2409
Copy link
Contributor

@LarsArtmann, Thank you for your contribution. I am very sorry for the late reply. We will work on proper notification.

Changing "vendor" folder isn't a good idea because it is auto-generated and all the manual changes will be lost.
I made this fix in go-namecheap-sdk and updated this terrafrom provider with this new SDK.

Terraform Provider v2.2.0 should work as you expected. Just let us know if you have any issues with it.

@vetal2409 vetal2409 closed this Nov 29, 2024
@LarsArtmann LarsArtmann deleted the patch-1 branch December 19, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants