Add Fill.asm tests + other small test script fixes #213
Conversation
| await versionUpdates[version](fs); | ||
| version++; | ||
| } catch (e) { | ||
| version++; |
There was a problem hiding this comment.
This should probably get logged somewhere but we don't have a good logging system
There was a problem hiding this comment.
Should I log it to the console for now?
There was a problem hiding this comment.
Hmm. So if a version doesn't work, we don't have its content in localstorage, which does put it an an inconsistent (but overall, usually functional) state. Probably a console.warn and a setStatus.
There was a problem hiding this comment.
setStatus will be immediately overriden by something else so I added an alert instead.
Is that okay?
There was a problem hiding this comment.
Definitely do not ever use alert. It is highly disruptive to any browser based workflow, and we should all just forget it exists.
Because we have ways to reset the loaded files, I think the best answer today is to use
console.warn(`Error loading files at version ${version}\`, e)
And at some point we'll come back and add proper application analytics logging.
No description provided.