Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler page offset when having too much tabs #460

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

netalondon
Copy link
Collaborator

Fixes #451

the line position: absolute !important; caused the issue.
disply: none; achieves the same effect.

@DavidSouther
Copy link
Collaborator

Unfortunately, this breaks keyboard interactions. The current form allows keyboard focus on the tabs to use the arrow keys to move tabs.

@netalondon
Copy link
Collaborator Author

We can do opacity: 0; instead, but this leaves a small gap after the label.

before:
Screenshot from 2024-09-16 18-04-16

after:
Screenshot from 2024-09-16 18-04-22

Is this good enough?

@DavidSouther
Copy link
Collaborator

How does it look by removing the position: absolute and setting opacity: 0; margin-inline: -1px;?

@netalondon
Copy link
Collaborator Author

How does it look by removing the position: absolute and setting opacity: 0; margin-inline: -1px;?

There's still a gap but smaller:
Screenshot from 2024-09-16 19-01-19

margin-inline: -7px; looks most similar to the initial version.
Should I just do that?

@DavidSouther
Copy link
Collaborator

It makes me a tiny bit uncomfortable, but just add a comment explaining why it's that way.

@DavidSouther DavidSouther merged commit 16641dd into nand2tetris:main Oct 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: Jack compiler - page slides after using a slider and clicking on a tab when there are a lot of files
2 participants