chore: Prettier config #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change prettierconfig to match code format add prettierconfig to scripts
DavidSouther
approved these changes
Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The .prettierconfig.yaml file didn't match the prettier code style that is actually used in this repo. For new contributors, that means that they will get the message "Code style issues found in 145 files" when they try to build the project. That leads to a cancellation of the build process, which results in not being able to "npm start" the project.
I updated the .prettierconfig.yaml to the settings that seem to be used in this repo. The only file that didn't match the settings is web/src/pico/pico.scss, which is included in this PR.
I also updated the scripts "npm run check:format" and "npm run format" to use the updated config file.