Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Retrieving ETH Transaction Receipt #61

Closed
avislash opened this issue Oct 15, 2021 · 4 comments
Closed

Add Support for Retrieving ETH Transaction Receipt #61

avislash opened this issue Oct 15, 2021 · 4 comments

Comments

@avislash
Copy link
Contributor

Add support for being able to retrieve an ETH Transaction Receipt (https://docs.etherscan.io/api-endpoints/geth-parity-proxy#eth_gettransactionreceipt)

@nanmu42
Copy link
Owner

nanmu42 commented Oct 17, 2021

Thanks for your contribution.

However, I had some doubt on our little package can handle proxy methods well.

Adding proxy methods would top-on much complexness and gotchas, as it speaks basically another language, with different API behavior, number representation and quirkers.

I would leave proxy methods out to keep the package simple and slim because of my limited maintenance power.

Avislash, your contribution does not come out in vain, it will always inspire and help people in the similiar needs. :)

@nanmu42
Copy link
Owner

nanmu42 commented Oct 18, 2021

Also closes #62 .

@nanmu42 nanmu42 closed this as completed Oct 18, 2021
@avislash
Copy link
Contributor Author

@nanmu42, I can respect your decision, however, I do need the proxy methods to be able to query the blockchain via Etherscan in order to get transaction receipts. Adding it to the library this way I don't need to use multiple services/API keys. I'll keep my fork up to facilitate my work in that regard and I'll push PRs back to this branch for future contributions.

@nanmu42
Copy link
Owner

nanmu42 commented Oct 19, 2021

Thanks for your understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants