PR for Supporting Get ETH Tx Receipt by Tx Hash #62
+175
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avislash
force-pushed
the
add-get-txnreceipt-by-hash
branch
from
c9d711f to
db1de1b
Compare
avislash
commented
Oct 15, 2021
| @@ -1,3 +1,8 @@ | |||
| module github.com/nanmu42/etherscan-api | |||
|
|
|||
| go 1.13 | |||
|
|
|||
| require ( | |||
There was a problem hiding this comment.
These only got added to make testing in proxy_e2e_test.go easier. I can simplify the test case by using a simpler txn receipt and test more similar to the other cases just let me know.
avislash
force-pushed
the
add-get-txnreceipt-by-hash
branch
from
b00a9dd to
90530de
Compare
|
CI fails because it can't access the ETHERSCAN_API_KEY secret. Not sure how to fix this, I have it set in my repo to a test key but for some reason it doesn't seem to be working. Any ideas on how to fix? |
avislash
force-pushed
the
add-get-txnreceipt-by-hash
branch
from
90530de to
6eb9c6e
Compare
Also: *Added Test for GetTxReceipt *Updated CI to download go mod dependencies
avislash
force-pushed
the
add-get-txnreceipt-by-hash
branch
from
6eb9c6e to
2ab97d1
Compare
|
Closed via #61 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#61