New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to extra parts documentation #496

Merged

Achllle merged 2 commits into nasa-jpl:master from igillespie:typos-in-documentation

Dec 2, 2024

Contributor

igillespie commented Nov 28, 2024

I made to two changes:

removed duplicate reference of PCA9685 controller
Changed description around PCA9685 to use 'steering servo driver' language instead of 'corner motor driver'.

I feel pretty good about change #1 as it really just fixes a typo. Number 2 I feel less confident about.

This is my first pull request!

igillespie added 2 commits

November 28, 2024 13:15


          removed duplicate mention of the PCA9685 corner motor driver

cb37450


          changed text in extra parts to make more clear that the PCA9685 is a …

66d227a

…servo driver and not a motor driver

Achllle approved these changes

View reviewed changes

Collaborator

Achllle left a comment

Excellent! Congrats on your first PR! Hopefully many more to follow.
And of course thank you for contributing to this volunteer-run project!

Achllle merged commit 7cd8c34 into nasa-jpl:master

1 of 2 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet