This repository has been archived by the owner on Nov 15, 2018. It is now read-only.
Check if gear does not have haproxy or distribute runs against non-scale... #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -8,6 +8,7 @@ require 'deployment' | |||
|
|
|||
| def read_gear_registry | |||
| gears = [] | |||
| if File.exists?(File.join(ENV['OPENSHIFT_HOMEDIR'], 'haproxy-1.4', 'conf', 'gear-registry.db')) | |||
There was a problem hiding this comment.
Would you mind fixing the indentation to be consistent with the rest of the file?
Also, instead of calling File.join twice, please extract a variable and use it in both places instead.
Thanks!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non scaled Openshift app does not have haproxy and If user run distribute command against non scaled openshift app, it gives error file not found due to which I added check.