Complete sso_bypass.sh #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andylytical
requested changes
Jul 3, 2024
There was a problem hiding this comment.
Please fix:
- Nothing happens when I run without any input. Expect it to print an error.
- Nothing happens if I don't give one of '-e' or '-d'. Expect it to print an error.
- My netrc has the PAT in the "account" field. Add an option to specify the key for netrc field that contains the token.
|
All of the issues were addressed. If user specify anything that is not -h, -e, or -d will get an error including running without input. Issue 3 was addressed by requiring user to specify the key value (password/account/...) when using the -e and -d options. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.