Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NEP-514: Reducing the number of Block Producer Seats in testnet #514

Merged
merged 6 commits into from
Nov 3, 2023
Merged

NEP-514: Reducing the number of Block Producer Seats in testnet #514

merged 6 commits into from
Nov 3, 2023

Conversation

nikurt
Copy link
Contributor

@nikurt nikurt commented Oct 25, 2023

No description provided.

@nikurt nikurt requested a review from a team as a code owner October 25, 2023 16:49
@render
Copy link

render bot commented Oct 25, 2023

Your Render PR Server URL is https://nomicon-pr-514.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-ckske2enfb1c73fjivag.

@nikurt nikurt mentioned this pull request Oct 25, 2023
Merged
@nikurt nikurt requested review from gmilescu and Longarithm October 26, 2023 09:41
gmilescu
gmilescu approved these changes Oct 26, 2023
View reviewed changes
Copy link

@gmilescu gmilescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The NEP looks good. Adapting the testnet size to the existing number of nodes simplifies testing.

@nikurt
Copy link
Contributor Author

nikurt commented Oct 27, 2023

ping @frol @ori-near

@nikurt nikurt mentioned this pull request Nov 1, 2023
Merged
frol
frol requested changes Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @nikurt for submitting this NEP, and sorry for the delay.

As a moderator, I reviewed this NEP and it meets the proposed template guidelines.

Since I see that the request comes from nearcore team and is approved by subject matter experts (@gmilescu and @wacban [on reference implementation PR]), I believe we should have moved to the REVIEW stage with @near/wg-protocol working group members reviewing and voting on it, BUT it seems that the PR to nearcore seems to be already merged, so I guess this is just a formality now. Overall, I don't want to make this process unnecessarily hard, so I am fine to rely on just a single vote from Protocol WG (@bowenwang1996, do you want to cast your Protocol WG vote here?)

neps/nep-0514.md Outdated Show resolved Hide resolved
@frol frol added WG-protocol Protocol Standards Work Group should be accountable S-voting/final-comment-period A NEP in the final REVIEW stage. Last chance to bring up concerns before the voting call. A-NEP A NEAR Enhancement Proposal (NEP). labels Nov 1, 2023
@nikurt nikurt requested a review from frol November 3, 2023 09:45
@frol frol added S-voting/needs-wg-voting-indication A NEP in the VOTING stage that needs the working group voting indication. and removed S-voting/final-comment-period A NEP in the final REVIEW stage. Last chance to bring up concerns before the voting call. labels Nov 3, 2023
@nikurt
Copy link
Contributor Author

nikurt commented Nov 3, 2023

@bowenwang1996 @mfornet @birchmd Please take a look

bowenwang1996
bowenwang1996 approved these changes Nov 3, 2023
View reviewed changes
Copy link
Collaborator

@bowenwang1996 bowenwang1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

frol
frol approved these changes Nov 3, 2023
View reviewed changes
Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on my previous comment and getting LGTM from the Protocol WG, I approve and merge this PR

@frol frol merged commit b9c3d15 into master Nov 3, 2023
4 checks passed
@frol frol deleted the testnet-fewer-bp branch November 3, 2023 22:02
@frol frol added S-approved A NEP that was approved by a working group. and removed S-voting/needs-wg-voting-indication A NEP in the VOTING stage that needs the working group voting indication. labels Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowenwang1996 bowenwang1996 bowenwang1996 approved these changes

@frol frol frol approved these changes

@gmilescu gmilescu gmilescu approved these changes

@Longarithm Longarithm Awaiting requested review from Longarithm

Assignees
No one assigned
Labels
A-NEP A NEAR Enhancement Proposal (NEP). S-approved A NEP that was approved by a working group. WG-protocol Protocol Standards Work Group should be accountable
Projects
NEPs
Status: APPROVED NEPs
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nikurt @gmilescu @frol @bowenwang1996