Adjust default step to 2

[neilenns]

Fixes #372

Summary by CodeRabbit

Release Notes

• New Features

  • Adjusted default volume change amount from 1 to 2 across main and station volume controls

• Bug Fixes

  • Ensured volume change amount is always at least 2 when not explicitly set
  • Improved volume control default settings for more consistent user experience

[coderabbitai]

Walkthrough

The pull request modifies the default volume change step across multiple files in the TrackAudio Stream Deck plugin. Changes are consistently applied to both main and station volume controllers, HTML configuration files, and related TypeScript files. The modifications increase the default volume change amount from 1 to 2, addressing a user experience concern about the step size being too slow.

Changes

File	Change Summary
com.neil-enns.trackaudio.sdPlugin/pi/mainVolume.html	Updated sdpi-range default value from "1" to "2"
com.neil-enns.trackaudio.sdPlugin/pi/stationVolume.html	Updated sdpi-range default value from "1" to "2"
src/controllers/mainVolume.ts	Modified changeAmount getter to default to 2 instead of 1
src/controllers/stationVolume.ts	Updated changeAmount getter to ensure minimum value of 2

Assessment against linked issues

Objective	Addressed	Explanation
Adjust default step to 2 [#372]	✅

Possibly related PRs

• Make checkboxes work correctly #369: Changes in stationVolume.html related to default range input configuration

Suggested labels

bug

Poem

🐰 Hop, hop, volume's on the rise!
From one to two, a swift surprise
Stream Deck dancing with delight
Volume stepping, crisp and bright
Rabbit's code, now swift and neat! 🎶

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3dbbf0a and 9d34ea0.

📒 Files selected for processing (4)

• com.neil-enns.trackaudio.sdPlugin/pi/mainVolume.html (1 hunks)
• com.neil-enns.trackaudio.sdPlugin/pi/stationVolume.html (1 hunks)
• src/controllers/mainVolume.ts (1 hunks)
• src/controllers/stationVolume.ts (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Build, lint and pack

🔇 Additional comments (5)

src/controllers/mainVolume.ts (1)

140-141: LGTM! Default step value correctly updated.

The implementation properly handles both the new default value of 2 and ensures a minimum value of 2 when settings are undefined or invalid.

src/controllers/stationVolume.ts (2)

208-209: LGTM! Consistent implementation with mainVolume.ts.

The changes mirror the implementation in mainVolume.ts, maintaining consistency across controllers.

---

105-107: LGTM! Improved comment formatting.

The comment formatting changes improve code readability.

com.neil-enns.trackaudio.sdPlugin/pi/mainVolume.html (1)

13-13: LGTM! UI default value aligned with controller.

The default value in the UI matches the implementation in the MainVolumeController.

com.neil-enns.trackaudio.sdPlugin/pi/stationVolume.html (1)

21-21: LGTM! Consistent default value across components.

The default value matches both the StationVolumeController implementation and mainVolume.html, maintaining consistency throughout the application.

Finishing Touches

• 📝 Generate Docstrings (Beta)

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Build for this pull request:
StreamDeck-TrackAudio.zip