Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DWF distribution checks #421

Merged
merged 6 commits into from
Dec 17, 2024
Merged

Add DWF distribution checks #421

merged 6 commits into from
Dec 17, 2024

Conversation

margrietpalm
Copy link
Contributor

Added checks for

  • Formatting of dry_weather_flow.distribution string
  • Number of values in dry_weather_flow.distribution (should be 24)
  • Sum of values in dry_weather_flow.distribution (should be 100)

elisalle
elisalle approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@elisalle elisalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, just one small typo

threedi_modelchecker/checks/other.py Outdated Show resolved Hide resolved
@margrietpalm margrietpalm merged commit 13ef997 into margriet_schema_300_leftovers Dec 17, 2024
7 checks passed
@margrietpalm margrietpalm deleted the margriet_420_dwf_checks branch December 17, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elisalle elisalle elisalle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@margrietpalm @elisalle