Add geometry match checks #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ries that should match objects * Move LinestringLocationCheck and derived checks to separate module * Move LinestringLocationCheck and related tests to seperate test file
elisalle
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a lot of checks that ensure that the geometries of objects match to the objects they are linked to. E.g. wether the geometry of a Pipe matches the line between the two connection nodes it connects.
For this I generalized LinestringLocationCheck to check for all linestrings. To limit complexity in config.py and to improve testability I created several subclasses for specific cases. For points I renamed CrossSectionLocationCheck to PointLocationCheck and generalized that check. These new / modified checks are moved to a new file (
location.py).Note I'm waiting for confirmation from Leendert that all new checks should be errors.Not going to wait, this can be fixed later.