Adapt to schema 230 (implicit CRS) #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
margrietpalm
commented
Dec 23, 2024
| @@ -324,7 +324,7 @@ def get_invalid(self, session: Session) -> List[NamedTuple]: | |||
| f"""SELECT * | |||
| FROM connection_node AS cn1, connection_node AS cn2 | |||
| WHERE | |||
| distance(cn1.geom, cn2.geom, 1) < :min_distance | |||
There was a problem hiding this comment.
The third argument, use_ellipsoid, is only suported for long/lat coordinates and will return None's for projected. Because from now on only projected should be allowed, this argument is removed.
… are no longer needed
margrietpalm
commented
Dec 23, 2024
There was a problem hiding this comment.
Removed these convenience functions because transformations are no longer needed when all geometries are in the same CRS and they are all projected and in meters. Keeping them is confusing imho and I prefer to directly use the geoalchemy functions.
elisalle
approved these changes
Dec 24, 2024
margrietpalm
added a commit
that referenced
this pull request
Jan 2, 2025
* Change CRS in all tests to 28892 * Disable RasterHasMatchingEPSGCheck (should be fixed in ticket 414) * Remove geo_query and use explicit queries instead now transformations are no longer needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify modelchecker to work with schematisation where all geometries use the model CRS and
model_settings.epsg_codeis no longer available. The goal of this work was to:epsg_code(317 and 318)In the process I tried to clean up the geometries used in testing.
Related PR for schema is currently being tested and will (preferably) be merged into master after the schema fixups