Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump github action versions #134

Merged
merged 2 commits into from
Dec 3, 2024
Merged

bump github action versions #134

merged 2 commits into from
Dec 3, 2024

Conversation

elisalle
Copy link
Contributor

No description provided.

margrietpalm
margrietpalm requested changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@margrietpalm margrietpalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This modifies the release workflow, but that is skipped in de CI. I would really like to see a succesfull release with these changes.

@elisalle
Copy link
Contributor Author

This modifies the release workflow, but that is skipped in de CI. I would really like to see a succesfull release with these changes.

how would you like me to test that before merging the PR?

@margrietpalm
Copy link
Contributor

This modifies the release workflow, but that is skipped in de CI. I would really like to see a succesfull release with these changes.

how would you like me to test that before merging the PR?

Create a tag with that results in a package with a name that pip doesn't automatically installs

@elisalle
Copy link
Contributor Author

elisalle commented Dec 2, 2024

tested and it works

margrietpalm
margrietpalm approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@margrietpalm margrietpalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@elisalle elisalle merged commit 6da0eea into master Dec 3, 2024
11 checks passed
@elisalle elisalle deleted the eli-bump-github-actions branch December 3, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@margrietpalm margrietpalm margrietpalm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elisalle @margrietpalm