Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-duplicate relationship projection when not using connection API #5936

Draft
wants to merge 5 commits into
base: 7.x
Choose a base branch
from

Conversation

mjfwebb
Copy link
Contributor

@mjfwebb mjfwebb commented Jan 10, 2025

Description

This PR introduces a change in the result projection where there are multiple relationships between two nodes.

In the case of using the connection API then multiple relationships will still be represented, as there is the ability to select the relationship properties. In the non-connection API case, the duplicate results will only return distinct results.

For example:

Data set:

CREATE (m:Movie} {title: "Movie One"})
CREATE (a:Actor} {name: "Actor One"})
CREATE (a)-[:ACTED_IN {role: "Role One"}]->(m)
CREATE (a)-[:ACTED_IN {role: "Role Two"}]->(m)

Connection API (actorsConnection):

query {
    movies {
        title
        actorsConnection {
            edges {
                node {
                    name
                }
                properties {
                    role
                }
            }
        }
    }
}

With the results:

movies: [
    {
        title: "Movie One",
        actorsConnection: {
            edges: expect.toIncludeSameMembers([
                {
                    node: {
                        name: "Actor One",
                    },
                    properties: {
                        role: "Role One",
                    },
                },
                {
                    node: {
                        name: "Actor One",
                    },
                    properties: {
                        role: "Role Two",
                    },
                },
            ]),
        },
    },
],

Non-connection API (actors):

query {
    movies {
        title
        actors {
            name
        }
    }
}

With the results:

movies: [
    {
        title: "Movie One",
        actors: [
            {
                name: "Actor One",
            },
        ],
    },
],

Complexity

Low

Copy link

changeset-bot bot commented Jan 10, 2025

🦋 Changeset detected

Latest commit: d48ea32

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@neo4j/graphql Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant