-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TASK: Correct typos in StyleAndUsage.rst #3381
Open
Safat99
wants to merge
2
commits into
neos:9.0
Choose a base branch
from
Safat99:patch-1
base: 9.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spelling mistakes found and corrected
jonnitto
requested changes
Jul 25, 2024
@Safat99, thank you for your PR! I leaved a comment on one thing, who should be changed. |
And I also think, the correct branch for this would be 8.3 |
jonnitto
changed the title
Update StyleAndUsage.rst
TASK: Correct typos in StyleAndUsage.rst
Jul 25, 2024
undoing the error of the previous commit
Do I need to change or push it to the 8.3 branch? |
@Safat99 Unfortunately I think you will have to cherry-pick to this to 8.3 and force push the PR branch, as just changing in Github would apply all other changes of 9.0 to the 8.3 branch as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spelling mistakes found and corrected
Upgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX
!!!
and have upgrade-instructions