Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Correct typos in StyleAndUsage.rst #3381

Open
wants to merge 2 commits into
base: 9.0
Choose a base branch
from
Open

Conversation

Safat99
Copy link

@Safat99 Safat99 commented Jul 25, 2024

spelling mistakes found and corrected

Upgrade instructions

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • The PR is created against the lowest maintained branch
  • Tests have been created, run and adjusted as needed
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

spelling mistakes found and corrected
@github-actions github-actions bot added the 9.0 label Jul 25, 2024
@jonnitto
Copy link
Member

@Safat99, thank you for your PR! I leaved a comment on one thing, who should be changed.

@jonnitto
Copy link
Member

And I also think, the correct branch for this would be 8.3

@jonnitto jonnitto changed the title Update StyleAndUsage.rst TASK: Correct typos in StyleAndUsage.rst Jul 25, 2024
@github-actions github-actions bot added the Task label Jul 25, 2024
@jonnitto jonnitto changed the base branch from 9.0 to 8.3 July 25, 2024 08:04
@jonnitto jonnitto changed the base branch from 8.3 to 9.0 July 25, 2024 08:04
undoing the error of the previous commit
@Safat99
Copy link
Author

Safat99 commented Jul 26, 2024

Do I need to change or push it to the 8.3 branch?

@Safat99 Safat99 closed this Jul 26, 2024
@Safat99 Safat99 reopened this Jul 26, 2024
@Safat99 Safat99 requested a review from jonnitto July 26, 2024 07:02
@kitsunet
Copy link
Member

kitsunet commented Jul 26, 2024

@Safat99 Unfortunately I think you will have to cherry-pick to this to 8.3 and force push the PR branch, as just changing in Github would apply all other changes of 9.0 to the 8.3 branch as well.

@Safat99 Safat99 mentioned this pull request Jul 26, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants