Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Fedora 38 support to OAI test case #260

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

electrocucaracha
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake

What this PR does / why we need it:
Until now, the creation of the sandbox has been tested with three OS releases, used for testing four different scenarios. This change offers the option to validate the Sandbox creation with fedora38, covering OAI test case.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@radoslawc
Copy link
Collaborator

/approve

@nephio-prow nephio-prow bot added the approved label Apr 26, 2024
@electrocucaracha
Copy link
Member Author

/retest

Signed-off-by: Victor Morales <[email protected]>
@radoslawc
Copy link
Collaborator

/retest

@arora-sagar
Copy link
Contributor

arora-sagar commented Apr 29, 2024

@electrocucaracha Thank you for this MR. Though is there any specific reason to choose Fedora 38? We can use 39, right?

@electrocucaracha
Copy link
Member Author

@electrocucaracha Thank you for this MR. Though is there any specific reason to choose Fedora 38? We can use 39, right?
I think that the Fedora39 image is not available in GCP, but I could be wrong

@arora-sagar
Copy link
Contributor

@electrocucaracha Thank you for this MR. Though is there any specific reason to choose Fedora 38? We can use 39, right?
I think that the Fedora39 image is not available in GCP, but I could be wrong

There is 39_Beta_39-20230912.0

@arora-sagar
Copy link
Contributor

@electrocucaracha Should we merge this MR as it is once the test passes?

@electrocucaracha
Copy link
Member Author

@electrocucaracha Should we merge this MR as it is once the test passes?

Let me give it another try

/test e2e-oai-fedora-38

@vjayaramrh
Copy link
Collaborator

/retest

@liamfallon
Copy link
Member

/approve

Copy link
Contributor

nephio-prow bot commented Jun 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liamfallon, radoslawc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liamfallon
Copy link
Member

/test e2e-oai-fedora-38

1 similar comment
@radoslawc
Copy link
Collaborator

/test e2e-oai-fedora-38

@efiacor
Copy link
Contributor

efiacor commented Dec 6, 2024

@arora-sagar , @radoslawc , should we bump this to fedora 41 instead?

@arora-sagar
Copy link
Contributor

@arora-sagar , @radoslawc , should we bump this to fedora 41 instead?

Yeah I totally agree we should upgrade to fedora 41

@electrocucaracha
Copy link
Member Author

Ok, let me rebase it and find the fedora images (last time that I checked GCP didn't have all of them available)

@efiacor
Copy link
Contributor

efiacor commented Dec 9, 2024

Ok, let me rebase it and find the fedora images (last time that I checked GCP didn't have all of them available)

We tried 41 here but like you say it's not available.
#318

@electrocucaracha
Copy link
Member Author

Ok, let me rebase it and find the fedora images (last time that I checked GCP didn't have all of them available)

We tried 41 here but like you say it's not available. #318

Got it, so in that case let's close this PR to avoid duplication

@efiacor
Copy link
Contributor

efiacor commented Dec 13, 2024

/test e2e-daily-fedora-38-kubeadm

Copy link
Contributor

nephio-prow bot commented Dec 13, 2024

@efiacor: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test presubmit-test-infra-inrepoconfig-validation

Use /test all to run all jobs.

In response to this:

/test e2e-daily-fedora-38-kubeadm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@liamfallon
Copy link
Member

/test e2e-oai-fedora-38

Copy link
Contributor

nephio-prow bot commented Dec 16, 2024

@liamfallon: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test presubmit-test-infra-inrepoconfig-validation

Use /test all to run all jobs.

In response to this:

/test e2e-oai-fedora-38

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@liamfallon
Copy link
Member

/test presubmit-test-infra-inrepoconfig-validation

Copy link
Contributor

nephio-prow bot commented Dec 16, 2024

@electrocucaracha: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
e2e-oai-fedora-38 9613c51 link false /test e2e-oai-fedora-38
presubmit-test-infra-inrepoconfig-validation 9613c51 link true /test presubmit-test-infra-inrepoconfig-validation

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants