Rename function for broadcasting extension events (#1717)

Rename function to make its purpose clear.
nerves-hub · Dec 27, 2024 · 9de4c7d · 9de4c7d
1 parent 17cbd78
commit 9de4c7d
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 12 deletions.
diff --git a/lib/nerves_hub/devices.ex b/lib/nerves_hub/devices.ex
@@ -1409,7 +1409,7 @@ defmodule NervesHub.Devices do
     |> Repo.update()
     |> tap(fn
       {:ok, _} ->
-        Extensions.toggle_extension(device, "attach", extension_string)
+        Extensions.broadcast_extension_event(device, "attach", extension_string)
 
       _ ->
         :nope
@@ -1423,7 +1423,7 @@ defmodule NervesHub.Devices do
     |> Repo.update()
     |> tap(fn
       {:ok, _} ->
-        Extensions.toggle_extension(device, "detach", extension_string)
+        Extensions.broadcast_extension_event(device, "detach", extension_string)
 
       _ ->
         :nope

diff --git a/lib/nerves_hub/extensions.ex b/lib/nerves_hub/extensions.ex
@@ -65,19 +65,15 @@ defmodule NervesHub.Extensions do
     :unsupported
   end
 
-  def toggle_extension(target, event, extension) do
-    device_internal_broadcast!(target, event, %{
-      "extensions" => [extension]
-    })
-  end
-
-  defp device_internal_broadcast!(target, event, payload) do
+  def broadcast_extension_event(target, event, extension) do
     Phoenix.Channel.Server.broadcast_from!(
       NervesHub.PubSub,
       self(),
       topic(target),
       event,
-      payload
+      %{
+        "extensions" => [extension]
+      }
     )
   end
 

diff --git a/lib/nerves_hub/products.ex b/lib/nerves_hub/products.ex
@@ -278,7 +278,7 @@ defmodule NervesHub.Products do
     |> Repo.update()
     |> tap(fn
       {:ok, _} ->
-        Extensions.toggle_extension(product, "attach", extension_string)
+        Extensions.broadcast_extension_event(product, "attach", extension_string)
 
       _ ->
         :nope
@@ -292,7 +292,7 @@ defmodule NervesHub.Products do
     |> Repo.update()
     |> tap(fn
       {:ok, _} ->
-        Extensions.toggle_extension(product, "detach", extension_string)
+        Extensions.broadcast_extension_event(product, "detach", extension_string)
 
       _ ->
         :nope