Move all audit logging to templates #1709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elinol
force-pushed
the
move-auditlogging-to-templates
branch
from
86a718e to
751fa5b
Compare
elinol
commented
Dec 28, 2024
elinol
commented
Dec 28, 2024
lib/nerves_hub/devices.ex
Outdated
| @@ -1091,6 +1070,7 @@ defmodule NervesHub.Devices do | |||
| {:ok, updated} | |||
|
|
|||
| err -> | |||
| Logger.warning("Could not move device: #{inspect(err)}") | |||
There was a problem hiding this comment.
will this be logged to sentry as well? @joshk
elinol
force-pushed
the
move-auditlogging-to-templates
branch
from
751fa5b to
ca603f7
Compare
nshoes
reviewed
Jan 10, 2025
nshoes
approved these changes
Jan 14, 2025
elinol
changed the title
elinol
force-pushed
the
move-auditlogging-to-templates
branch
from
4157586 to
e4ef887
Compare
This reverts commit ca603f7.
Add moduledocs and function specs.
elinol
force-pushed
the
move-auditlogging-to-templates
branch
from
3d8e541 to
0ee4737
Compare
joshk
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves all audit logging to the template module.
One exception is in the function
Devices.update_device_with_audit/4where the audit log description is passed via the updating action (liketag_devicefor example). I don't know if it's worth it adding this to templates, since the templates themselves (the description) are defined outside the templates module. Any input on this is welcomed!