Code

The Credo experiment#1740

Code

Merged

joshk merged 29 commits intomainnerves-hub/nerves_hub_web:mainfrom the-credo-experimentnerves-hub/nerves_hub_web:the-credo-experimentCopy head branch name to clipboardJan 11, 2025

+768-385

Commits

Commits on Jan 7, 2025

• Add credo to our CI, but don't fail just yet

  joshk

  committed
  1fddd55

  Copy full SHA for 1fddd55

• Ignore the moduledocs on some files

  joshk

  committed
  c9c01bd

  Copy full SHA for c9c01bd

• Enum.empty?/1 is better than length/1

  joshk

  committed
  2bee005

  Copy full SHA for 2bee005

• Large numbers should use an underscore

  joshk

  committed
  c6d74b6

  Copy full SHA for c6d74b6

• Encapsulate the multi template processing

  joshk

  committed
  0f41493

  Copy full SHA for 0f41493

• Don't use is_ if the function uses ?

  joshk

  committed
  ebab680

  Copy full SHA for ebab680

• Use case instead of a single statement with

  joshk

  committed
  8123d79

  Copy full SHA for 8123d79

• Enum.count/2 is faster

  joshk

  committed
  c7fc7bf

  Copy full SHA for c7fc7bf

• More device filtering logic to its own module

  Show description for 733afea
  joshk

  committed
  733afea

  Copy full SHA for 733afea

• Remove an old TODO comment

  joshk

  committed
  c3a45d0

  Copy full SHA for c3a45d0

• Reduce nesting and improve readability

  joshk

  committed
  dafcb59

  Copy full SHA for dafcb59

• Use consistent exception naming

  joshk

  committed
  573ab96

  Copy full SHA for 573ab96

• Remove one unneeded statement in a with

  joshk

  committed
  88488c7

  Copy full SHA for 88488c7

Commits on Jan 8, 2025

• Order (and expand) aliass

  joshk

  committed
  5a7301f

  Copy full SHA for 5a7301f

• Alias some nested modules

  joshk

  committed
  ae7d231

  Copy full SHA for ae7d231

• Add a module doc and remove a duplicate alias

  joshk

  committed
  6756a22

  Copy full SHA for 6756a22

• Match a preload function return (Dialyzer fix)

  joshk

  committed
  8e33fe3

  Copy full SHA for 8e33fe3

• Remove the need for Repo in a LiveView

  joshk

  committed
  56bbeb1

  Copy full SHA for 56bbeb1

• Update credo config

  joshk

  committed
  3e70054

  Copy full SHA for 3e70054

• Remove an incorrect alias that snuck in

  joshk

  committed
  cfb8820

  Copy full SHA for cfb8820

• Remove some duplicated exception code

  Show description for 8e3ff25
  joshk

  committed
  8e3ff25

  Copy full SHA for 8e3ff25

Commits on Jan 11, 2025

• TODO comments aren't bad, so lets not exit on them.

  Show description for 8a08682
  

  joshk

  and

  jjcarstens

  authored
  8a08682

  Copy full SHA for 8a08682

• Enable MultiAlias credo checks

  joshk

  committed
  066d24c

  Copy full SHA for 066d24c

• Enable ImplTrue credo checks

  joshk

  committed
  f337fc1

  Copy full SHA for f337fc1

• Enable the LeakyEnvironment credo check

  joshk

  committed
  48f0e3e

  Copy full SHA for 48f0e3e

• Merge branch 'main' into the-credo-experiment

  joshk

  committed
  c8ebec7

  Copy full SHA for c8ebec7

• Credo: Fix some alias ordering

  joshk

  committed
  b5f2a97

  Copy full SHA for b5f2a97

• Require parentheses on zero arity functions

  Show description for 90d5fab
  joshk

  committed
  90d5fab

  Copy full SHA for 90d5fab

• Start enforcing our evolving style guide

  joshk

  committed
  0d75f5b

  Copy full SHA for 0d75f5b