Allow devices to have empty firmware when checking for deployments #1749
Conversation
…gable deployments
|
Oops, approved too soon... could we get a test for this? :) |
|
Yes, I was thinking so too. First thing monday! |
There was a problem hiding this comment.
Sooooo, I have an idea I would like to run past everyone.
How about we list all deployments, and include in the drop down the aarch and platform of the deployment, allowing for the device to be added to the deployment, and instead add a note under the dropdown or a flash message that the device will be removed from the deployment upon connection if the aarch and platform of the device doesn't match.
This feels like a nicer user experience as a device can be manually added, if it be via api or UI, and placed in a deployment (if tags aren't used for matching). If we don't allow this then we require the device to connect, which can remove users from there flow of learning the system.
Fixes a bug (#1748 ) where the liveview crashes when trying to show a device without firmware metadata.