Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Duplicate html tag ids on the Devices list page #1757

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/nerves_hub_web/live/devices/index.html.heex
Original file line number Diff line number Diff line change
Expand Up @@ -194,10 +194,10 @@

<div class="row mt-2">
<form id="move-product" class="col-lg-4" phx-change="target-product" phx-submit="move-devices-product">
<label for="move_to">Move device(s) to product:</label>
<label for="move_to_product">Move device(s) to product:</label>
<div class="flex-row align-items-center">
<div class="flex-grow pos-rel">
<select name="product" id="move_to" class="form-control">
<select name="product" id="move_to_product" class="form-control">
<option value=""></option>
<%= for org <- @user.orgs, products = org.products, length(products) > 0 do %>
<optgroup label={org.name}>
Expand Down Expand Up @@ -235,10 +235,10 @@
</form>

<form id="move-deployment" class="col-lg-4" phx-change="target-deployment" phx-submit="move-devices-deployment">
<label for="move_to">Move device(s) to deployment:</label>
<label for="move_to_deployment">Move device(s) to deployment:</label>
<div class="flex-row align-items-center">
<div class="flex-grow pos-rel">
<select name="deployment" id="move_to" class="form-control">
<select name="deployment" id="move_to_deployment" class="form-control">
<option value=""></option>
<%= for deployment <- @deployments do %>
<option value={deployment.id} {if @target_deployment && @target_deployment.id == deployment.id, do: [selected: true], else: []}><%= deployment.name %></option>
Expand Down
Loading