Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New UI: Improve the readability of the device list progress bar #1814

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

joshk
Copy link
Collaborator

@joshk joshk commented Jan 23, 2025

Before:

Screen.Recording.2025-01-23.at.3.47.20.PM.mov

I felt the radial background was too muted, and it wasn't clear which device the solid green bar was for (think of a device that is half way down the list)

Now:

Screen.Recording.2025-01-23.at.4.32.33.PM.mov

I've added a progress bar label, removed the top line, and tweaked the gradient a little

@joshk joshk requested review from lawik and nshoes and removed request for lawik January 23, 2025 03:42
Copy link
Contributor

@nshoes nshoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 🚀

@lawik
Copy link
Contributor

lawik commented Jan 23, 2025

This was my first approach. I do really like the line. I guess this is more clear though.
What about this and the line? Did you try that?

This definitely works.

I like the progress label. Makes it very clear that an update is in progress. I think if the numeric part of that has a fixed width it would not jiggle the layout except when it shows up and goes away.

I'll try a variation :D

@joshk
Copy link
Collaborator Author

joshk commented Jan 23, 2025

Yep, I did try this and the line: (a slightly earlier variation)

Screen.Recording.2025-01-23.at.4.00.02.PM.mov

What I didn't think worked well was when the device that was updating was half way down the list, the line looked like it might be part of the device above. I'm not sure how to describe it, it felt a little busy.

Just the updating background is my preference.

@lawik
Copy link
Contributor

lawik commented Jan 23, 2025

Variant here: #1816

It is essentially the one in Josh's video above. I prefer that one :D
I also dropped the percentages from the updating label which should reduce table-jiggle a lot.

If you can't tell I really like the thin progress bar :D 


![Screenshot_20250123_095813](https://github.com/user-attachments/assets/6b6065f4-40d7-4825-9dbe-a0f2a055ec3f)

This uses the fix of the background from:
#1814

But it also uses the thin stripe.

For simplicity I cut the % display in the label. I think the label is
helpful but it was making the whole table jiggle and it would be a bunch
of faffing about to make it behave nice.
@joshk joshk closed this Jan 23, 2025
@joshk joshk reopened this Jan 23, 2025
@joshk joshk merged commit dd79ab4 into main Jan 23, 2025
4 checks passed
@joshk joshk deleted the new-ui-tweak-the-devices-progress-bar branch January 23, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants