-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose Entity Registration Conversation Options #1167
Expose Entity Registration Conversation Options #1167
Conversation
I can't seem to edit the labels now, but this should be an enhancement |
I fixed that but the CI still seem to fail. Please investigate. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1167 +/- ##
====================================
- Coverage 86% 86% -1%
====================================
Files 189 193 +4
Lines 3781 3797 +16
Branches 424 425 +1
====================================
+ Hits 3288 3299 +11
- Misses 492 497 +5
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Cleaned up the coverage and fixed the tests, should be good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you for your effort!
Proposed change
This deserializes the
options
andconversation
fields from the entity registry. I have limited data there (only Assist, no Alexa/GA), so I started with the field that was most relevant to my needs, but could easily be expanded if someone wants to provide a sample containing Alexa/Google Assistant settings.Type of change
Additional information
Checklist
If user exposed functionality or configuration are added/changed: