Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Entity Registration Conversation Options #1167

Merged
merged 6 commits into from
Sep 11, 2024
Merged

Expose Entity Registration Conversation Options #1167

merged 6 commits into from
Sep 11, 2024

Conversation

spelech
Copy link
Contributor

@spelech spelech commented Sep 3, 2024

Proposed change

This deserializes the options and conversation fields from the entity registry. I have limited data there (only Assist, no Alexa/GA), so I started with the field that was most relevant to my needs, but could easily be expanded if someone wants to provide a sample containing Alexa/Google Assistant settings.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • The code compiles without warnings (code quality check)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration are added/changed:

@spelech spelech marked this pull request as draft September 3, 2024 14:07
@spelech spelech marked this pull request as ready for review September 3, 2024 14:08
@spelech
Copy link
Contributor Author

spelech commented Sep 3, 2024

I can't seem to edit the labels now, but this should be an enhancement

@helto4real
Copy link
Collaborator

I can't seem to edit the labels now, but this should be an enhancement

I fixed that but the CI still seem to fail. Please investigate.

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86%. Comparing base (eb6227f) to head (a795637).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff          @@
##           main   #1167   +/-   ##
====================================
- Coverage    86%     86%   -1%     
====================================
  Files       189     193    +4     
  Lines      3781    3797   +16     
  Branches    424     425    +1     
====================================
+ Hits       3288    3299   +11     
- Misses      492     497    +5     
  Partials      1       1           
Flag Coverage Δ
unittests 86% <100%> (-1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spelech
Copy link
Contributor Author

spelech commented Sep 8, 2024

Cleaned up the coverage and fixed the tests, should be good to go.

Copy link
Collaborator

@helto4real helto4real left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for your effort!

@helto4real helto4real enabled auto-merge (squash) September 11, 2024 20:40
@helto4real helto4real disabled auto-merge September 11, 2024 20:45
@helto4real helto4real merged commit 4a090e9 into net-daemon:main Sep 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants