Avoid Exceptions when AppConfigPath does not exist #1218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1218 +/- ##
====================================
- Coverage 82% 82% -1%
====================================
Files 196 196
Lines 3845 3840 -5
Branches 425 426 +1
====================================
- Hits 3164 3159 -5
Misses 516 516
Partials 165 165
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
helto4real
approved these changes
Dec 23, 2024
| @@ -115,13 +113,6 @@ private async Task LoadNewAppContextAsync(IHomeAssistantConnection haConnection, | |||
| var appModel = serviceProvider.GetService<IAppModel>(); | |||
| if (appModel == null) return; | |||
|
|
|||
| // this logging is a bit weird in this class | |||
| if (!string.IsNullOrEmpty(locationSettings.Value.ApplicationConfigurationFolder)) | |||
There was a problem hiding this comment.
I think this could be a good option to have as a debug log rather than default to be able to track down configuration issues. It is not as important when running it through a container but in other scenarios it can.
|
|
||
| public IReadOnlyCollection<SyntaxTree> GetSyntaxTrees() | ||
| { | ||
| logger.LogDebug("Loading applications from folder {Path}", _settings.ApplicationConfigurationFolder); |
There was a problem hiding this comment.
Ohh never mind the logging comment, you moved it here instead. Yea that is better!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Type of change
Additional information
Checklist
If user exposed functionality or configuration are added/changed: