Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposed fix for Issue #234 #242

Merged
merged 8 commits into from
Dec 16, 2024
Merged

Proposed fix for Issue #234 #242

merged 8 commits into from
Dec 16, 2024

Conversation

GaetanoCarlucci
Copy link
Contributor

@GaetanoCarlucci GaetanoCarlucci commented Dec 6, 2024 •
edited by mtarking
Loading

Related Issue(s)

Proposed fix to resolve #234

Related Collection Role

  • cisco.nac_dc_vxlan.validate
  • cisco.nac_dc_vxlan.dtc.create
  • cisco.nac_dc_vxlan.dtc.deploy
  • cisco.nac_dc_vxlan.dtc.remove
  • other

Related Data Model Element

  • vxlan.global
  • vxlan.topology
  • vxlan.underlay
  • vxlan.overlay_services
  • vxlan.overlay_extensions
  • vxlan.policy
  • defaults.vxlan
  • other

Proposed Changes

Proposed fix for Issue #234

Test Notes

Cisco NDFC Version

Checklist

  • Latest commit is rebased from develop with merge conflicts resolved
  • New or updates to documentation has been made accordingly
  • Assigned the proper reviewers

@GaetanoCarlucci GaetanoCarlucci requested a review from a team as a code owner December 6, 2024 11:38
@devegupt devegupt self-requested a review December 6, 2024 14:12
@juburnet juburnet added the ready for review PR Ready for Review label Dec 6, 2024
devegupt
devegupt requested changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@devegupt devegupt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this code and it works, but I suggested a minor change for improving if condition.

roles/dtc/common/templates/ndfc_vrf_lite.j2 Outdated Show resolved Hide resolved
@GaetanoCarlucci
adding spaces as suggested in the review
f17b0c7 
adding spaces as suggested in the review
@juburnet juburnet removed the ready for review PR Ready for Review label Dec 12, 2024
devegupt
devegupt approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@devegupt devegupt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@juburnet juburnet added the ready for review PR Ready for Review label Dec 13, 2024
juburnet
juburnet approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@juburnet juburnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed indentation and file structure.

@mikewiebe mikewiebe merged commit 5234e7c into netascode:develop Dec 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtarking mtarking mtarking left review comments

@juburnet juburnet juburnet approved these changes

@devegupt devegupt devegupt approved these changes

@mikewiebe mikewiebe mikewiebe approved these changes

Assignees
No one assigned
Labels
ready for review PR Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In vrf_lite, if bgp is not defined at global level, config is not rendered
5 participants
@GaetanoCarlucci @mikewiebe @mtarking @devegupt @juburnet