use proper credentials for mysql root

netbirdio · Jan 19, 2025 · 3525837 · 3525837
1 parent 8849b40
commit 3525837
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/.github/workflows/golang-test-linux.yml b/.github/workflows/golang-test-linux.yml
@@ -228,7 +228,7 @@ jobs:
         if: matrix.store == 'mysql'
         run: |
           for i in {1..10}; do
-            if docker exec my-mysql mysqladmin -uroot ping &>/dev/null; then
+            if nc -z localhost 3306; then
               break
             fi
             echo "Waiting for MySQL..."
@@ -242,7 +242,7 @@ jobs:
           fi
               
           if [ "${{ matrix.store }}" = "mysql" ]; then
-            export NETBIRD_STORE_ENGINE_MYSQL_DSN="root:@tcp(localhost:3306)/netbird?parseTime=True"
+            export NETBIRD_STORE_ENGINE_MYSQL_DSN="root:testing@tcp(localhost:3306)/testing?parseTime=True"
           fi
           
           CGO_ENABLED=1 GOARCH=${{ matrix.arch }} \
@@ -334,8 +334,6 @@ jobs:
         if: matrix.store == 'mysql'
         run: |
           docker run -d \
-            -e MYSQL_ROOT_PASSWORD=netbird \
-            -e MYSQL_DATABASE=netbird \
             -p 3306:3306 \
             --name my-mysql \
             mlsmaycon/warmed-mysql:8
@@ -558,8 +556,6 @@ jobs:
         if: matrix.store == 'mysql'
         run: |
           docker run -d \
-            -e MYSQL_ROOT_PASSWORD=netbird \
-            -e MYSQL_DATABASE=netbird \
             -p 3306:3306 \
             --name my-mysql \
             mlsmaycon/warmed-mysql:8
@@ -584,7 +580,7 @@ jobs:
           fi
           
           if [ "${{ matrix.store }}" = "mysql" ]; then
-            export NETBIRD_STORE_ENGINE_MYSQL_DSN="root:netbird@tcp(localhost:3306)/netbird?parseTime=True"
+            export NETBIRD_STORE_ENGINE_MYSQL_DSN="root:testing@tcp(localhost:3306)/testing?parseTime=True"
           fi
           
           CGO_ENABLED=1 GOARCH=${{ matrix.arch }} \