Engine should restart and block more restarts

[hurricanehrndz]

Describe your changes

Block rapid restarts in succession for 3s.

Issue ticket number and link

Possible fix for #2196 #2011

Checklist

• Is it a bug fix
• Is a typo/documentation fix
• Is a feature enhancement
• It is a refactor
• Created tests that fail without the change (if possible)
• Extended the README / documentation, if necessary

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[lixmal]

What problem is this solving? Would increasing the timeout suffice?

[hurricanehrndz]

What problem is this solving? Would increasing the timeout suffice?

Increasing the timeout might. The only difference between your approach and this approach is that engine restart is initiate and then blocked, meanwhile the current code base waits to restart. Either way as long as utun100 resource busy is no longer happening this can be closed

We should wait until @christian-schlichtherle or @fadyHemaya have responded to the issues to confirm 28.5+ and the current code base doesn't result in utun100 resource busy.

[lixmal]

What problem is this solving? Would increasing the timeout suffice?

The only difference between your approach and this approach is that engine restart is initiate and then blocked, meanwhile the current code base waits to restart.

We need to pick up the latest network state (routes), that's why we cannot just ignore changes for X seconds.
If we miss the latest change in a row of route changes we might set up routes pointing to the wrong thing and netbird might be broken. I don't mind increasing the timeout, though.

[hurricanehrndz]

Good point, thank you for the clarification Get Outlook for iOS<https://aka.ms/o0ukef>

…

________________________________ From: Viktor Liu ***@***.***> Sent: Friday, August 9, 2024 11:01:35 AM To: netbirdio/netbird ***@***.***> Cc: Carlos Hernandez ***@***.***>; Author ***@***.***> Subject: Re: [netbirdio/netbird] Engine should restart and block more restarts (PR #2406) What problem is this solving? Would increasing the timeout suffice? The only difference between your approach and this approach is that engine restart is initiate and then blocked, meanwhile the current code base waits to restart. We need to pick up the latest network state (routes), that's why we cannot just ignore changes for X seconds. If we miss the latest change in a row of route changes we might set up routes pointing to the wrong thing and netbird might be broken. I don't might increasing the timeout, though. — Reply to this email directly, view it on GitHub<#2406 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABMJBTJ3PYG62BU5FVPPNVDZQTYW7AVCNFSM6AAAAABMEURTTOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZYGM3TAMZRGY>. You are receiving this because you authored the thread.Message ID: ***@***.***>