Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[management] Refactor routes to use store methods #2928

Open
wants to merge 5 commits into
base: users-get-account-refactoring
Choose a base branch
from
Open

[management] Refactor routes to use store methods #2928

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
de3e67e
Add route store methods
bcmmbaga Nov 21, 2024
24970a1
Refactor get and save accounts in route ops
bcmmbaga Nov 21, 2024
f42c775
Add tests
bcmmbaga Nov 22, 2024
c52e4f9
Merge branch 'users-get-account-refactoring' into routes-get-account-…
bcmmbaga Jan 17, 2025
397c2a7
Fix merge
bcmmbaga Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions management/server/group.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -642,15 +642,6 @@ func areGroupChangesAffectPeers(ctx context.Context, transaction store.Store, ac
return false, nil
}

func (am *DefaultAccountManager) anyGroupHasPeers(account *types.Account, groupIDs []string) bool {
for _, groupID := range groupIDs {
if group, exists := account.Groups[groupID]; exists && group.HasPeers() {
return true
}
}
return false
}

// anyGroupHasPeersOrResources checks if any of the given groups in the account have peers or resources.
func anyGroupHasPeersOrResources(ctx context.Context, transaction store.Store, accountID string, groupIDs []string) (bool, error) {
groups, err := transaction.GetGroupsByIDs(ctx, store.LockingStrengthShare, accountID, groupIDs)
Expand Down
Loading
Loading